Code review comment for lp:~frankban/juju-quickstart/env-manage-models-meta

Revision history for this message
Francesco Banconi (frankban) wrote :

Reviewers: mp+198756_code.launchpad.net,

Message:
Please take a look.

Description:
Implement the missing model bits.

Thanks to Gary for his help in defining
this approach with me in several pre-imp
calls.

See the envs module docstring for a
description of the functions implemented
in this branch.

This branch also includes some
fixes/improvements to the fields module,
e.g. the handling of default and unset values.

Tests: make check
No QA.

https://code.launchpad.net/~frankban/juju-quickstart/env-manage-models-meta/+merge/198756

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/41350043/

Affected files (+688, -39 lines):
   A [revision details]
   M quickstart/models/envs.py
   M quickstart/models/fields.py
   M quickstart/tests/models/test_envs.py
   M quickstart/tests/models/test_fields.py

« Back to merge proposal