Code review comment for lp:~frankban/juju-quickstart/env-manage-base-views

Revision history for this message
Francesco Banconi (frankban) wrote :

Reviewers: mp+199254_code.launchpad.net,

Message:
Please take a look.

Description:
Quickstart base structure for views.

This branch implements a way to start
Urwid interactive sessions in quickstart.
This infrastructure will be used in
future branches to implement the
quickstart environment management system.

My apologies for the long diff, but you
can safely ignore all the file headers,
and the code includes long module
docstrings which can help reviewing the
branch.

Tests: `make check`.

QA:
run `make` and then `./cli-app-demo.py`:
this will start a demo application using
the views infrastructure.

Thank you!

https://code.launchpad.net/~frankban/juju-quickstart/env-manage-base-views/+merge/199254

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/42600044/

Affected files (+913, -1 lines):
   A [revision details]
   A cli-app-demo.py
   A quickstart/cli/__init__.py
   A quickstart/cli/base.py
   A quickstart/cli/ui.py
   A quickstart/cli/views.py
   M quickstart/models/envs.py
   A quickstart/tests/cli/__init__.py
   A quickstart/tests/cli/test_base.py
   A quickstart/tests/cli/test_ui.py
   A quickstart/tests/cli/test_views.py
   M quickstart/tests/test_utils.py
   M quickstart/utils.py
   M requirements.pip

« Back to merge proposal