Merge lp:~frankban/juju-quickstart/changeset-prep into lp:juju-quickstart
Proposed by
Francesco Banconi
Status: | Merged |
---|---|
Merged at revision: | 127 |
Proposed branch: | lp:~frankban/juju-quickstart/changeset-prep |
Merge into: | lp:juju-quickstart |
Diff against target: |
99 lines (+17/-10) 4 files modified
quickstart/manage.py (+1/-1) quickstart/models/bundles.py (+7/-3) quickstart/tests/models/test_bundles.py (+5/-2) tox.ini (+4/-4) |
To merge this branch: | bzr merge lp:~frankban/juju-quickstart/changeset-prep |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Brad Crittenden (community) | code | Approve | |
Review via email: mp+257387@code.launchpad.net |
Description of the change
Some small changes in preparation for change sets.
Extend the services method of the bundle model to
include the number of units for each service.
Use the newer jujubundlelib.
To post a comment you must log in.
Reviewers: mp+257387_ code.launchpad. net,
Message:
Please take a look.
Description:
Some small changes in preparation for change sets.
Extend the services method of the bundle model to
include the number of units for each service.
Use the newer jujubundlelib.
https:/ /code.launchpad .net/~frankban/ juju-quickstart /changeset- prep/+merge/ 257387
(do not edit description out of merge proposal)
Please review this at https:/ /codereview. appspot. com/231120043/
Affected files (+19, -10 lines): manage. py models/ bundles. py tests/models/ test_bundles. py
A [revision details]
M quickstart/
M quickstart/
M quickstart/
M tox.ini
Index: [revision details]
=== added file '[revision details]'
--- [revision details] 2012-01-01 00:00:00 +0000
+++ [revision details] 2012-01-01 00:00:00 +0000
@@ -0,0 +1,2 @@
+Old revision:
<email address hidden>
+New revision:
<email address hidden>
Index: tox.ini /launchpad. net/~juju/ +archive/ ubuntu/ stable. -client= =0.18.0 t==0.50. 1 =0.1.3 =0.1.4
=== modified file 'tox.ini'
--- tox.ini 2015-04-23 09:00:26 +0000
+++ tox.ini 2015-04-24 13:31:28 +0000
@@ -72,7 +72,7 @@
# See https:/
websocket
jujuclien
- jujubundlelib=
+ jujubundlelib=
urwid==1.2.1
# The distribution PyYAML requirement is used in this case.
@@ -82,7 +82,7 @@ -client= =0.12.0 t==0.17. 5 =0.1.3 =0.1.4
# Ubuntu 14.04 (trusty) distro dependencies.
websocket
jujuclien
- jujubundlelib=
+ jujubundlelib=
PyYAML==3.10
urwid==1.1.1
@@ -92,7 +92,7 @@ -client= =0.12.0 t==0.17. 5 =0.1.3 =0.1.4
# Ubuntu 14.10 (utopic) distro dependencies.
websocket
jujuclien
- jujubundlelib=
+ jujubundlelib=
PyYAML==3.11
urwid==1.2.1
@@ -102,7 +102,7 @@ -client= =0.18.0 t==0.18. 5 =0.1.3 =0.1.4
# Ubuntu 15.04 (vivid) distro dependencies.
websocket
jujuclien
- jujubundlelib=
+ jujubundlelib=
PyYAML==3.11
urwid==1.2.1
Index: quickstart/ manage. py manage. py' manage. py 2015-04-21 10:22:46 +0000 manage. py 2015-04-24 13:31:28 +0000
=== modified file 'quickstart/
--- quickstart/
+++ quickstart/
@@ -575,7 +575,7 @@
# Handle bundle deployment. bundle_ source is not None: options. bundle. services( )) options. bundle. services( ).keys( ))
print( 'requesting a deployment of {} with the following options. bundle, services)) bundle. reference is not None:
if options.
- services = ', '.join(
+ services = ', '.join(
services:\n'
' {}'.format(
if options.
Index: quickstart/ models/ bundles. py models/ bundles. py' models/ bundles. py 2015-04-23 12:09:29 +0000 models/ bundles. py 2015-04-24 13:31:28 +0000 yaml_dump( {'bundle' : self.data})
=== modified file 'quickstart/
--- quickstart/
+++ quickstart/
@@ -106,11 +106,15 @@
return serializers.
def services(self):
- """Return a list of service names included in the bundle.
+ """Return an ordered dict mapping services and their number of
units.
- Service names are returned in alphabetical order.
+ In the dict, service names are returned in alphabetical order.
...