Code review comment for lp:~frankban/juju-quickstart/changeset-from-jujubundlelib

On 2015/04/23 14:02:41, jeff.pihach wrote:
> LGTM!

https://codereview.appspot.com/232890043/diff/20001/quickstart/models/bundles.py
> File quickstart/models/bundles.py (right):

https://codereview.appspot.com/232890043/diff/20001/quickstart/models/bundles.py#newcode389
> quickstart/models/bundles.py:389: if settings.JUJU_GUI_SERVICE_NAME in
> data['services'].keys():
> I'm wondering if we shouldn't be a little bit more proactive here by
throwing a
> warning to the user but then continuing on ignoring that they supplied
their own
> GUI instance. We could possibly even try to apply their supplied GUI
config.

Thanks for the review!
This is a good suggestion. Something like this can be implemented later,
but it's not trivial in the current approach which makes use of the
deployer in the backend.

https://codereview.appspot.com/232890043/