Code review comment for lp:~frankban/juju-quickstart/changeset-from-jujubundlelib

Revision history for this message
Jeff Pihach (hatch) wrote :

LGTM!

https://codereview.appspot.com/232890043/diff/20001/quickstart/models/bundles.py
File quickstart/models/bundles.py (right):

https://codereview.appspot.com/232890043/diff/20001/quickstart/models/bundles.py#newcode389
quickstart/models/bundles.py:389: if settings.JUJU_GUI_SERVICE_NAME in
data['services'].keys():
I'm wondering if we shouldn't be a little bit more proactive here by
throwing a warning to the user but then continuing on ignoring that they
supplied their own GUI instance. We could possibly even try to apply
their supplied GUI config.

https://codereview.appspot.com/232890043/

« Back to merge proposal