Code review comment for lp:~frankban/juju-quickstart/add-tox
Revision history for this message
| Brad Crittenden (bac) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
(Get the code!)
Code is LGTM with the one suggestion for the Makefile.
QA OK on trusty
On OS X, the 'make sysdeps' suggests you use brew to install python-dev
python-setuptools and python-pip. Those package names are not the same
in brew and pip is installed via 'brew install python'. I'm not sure if
the equivalent of python-dev gets installed but 'make check' ran fine.
Perhaps you can adjust the message to be less misleading.
https:/
File Makefile (right):
https:/
Makefile:44:
It is a bit odd to touch the canary on an non-Debian system when the
sysdeps were not installed.
https:/