LGTM. Did not try to QA yet. Tox may be very interesting for lots of our projects.
https://codereview.appspot.com/189580044/diff/1/HACKING.rst File HACKING.rst (right):
https://codereview.appspot.com/189580044/diff/1/HACKING.rst#newcode356 HACKING.rst:356: parsing ``tox.ini``, dependencies must be listed with the following rules: Could you try to re-word that sentence? I'm not sure what you're saying.
https://codereview.appspot.com/189580044/diff/1/HACKING.rst#newcode358 HACKING.rst:358: - each scenario must at least include a "{[testenv]deps}" line in its deps: Change the : to ; or ,
https://codereview.appspot.com/189580044/diff/1/MANIFEST.in File MANIFEST.in (right):
https://codereview.appspot.com/189580044/diff/1/MANIFEST.in#newcode24 MANIFEST.in:24: # tox.ini file, removing it from this list will break the source distribution Again, this could be worded better.
https://codereview.appspot.com/189580044/diff/1/setup.py File setup.py (right):
https://codereview.appspot.com/189580044/diff/1/setup.py#newcode43 setup.py:43: """Return Juju Quickstart package data by walking through the project.""" A better explanation of what "package data" is would be nice.
https://codereview.appspot.com/189580044/diff/1/setup.py#newcode74 setup.py:74: for requirement in deps: Maybe add
requirement = requirement.strip()
https://codereview.appspot.com/189580044/diff/1/tox.ini File tox.ini (right):
https://codereview.appspot.com/189580044/diff/1/tox.ini#newcode42 tox.ini:42: basepython = python2.7 Is it required to repeat here?
https://codereview.appspot.com/189580044/
« Back to merge proposal
LGTM. Did not try to QA yet. Tox may be very interesting for lots of our
projects.
https:/ /codereview. appspot. com/189580044/ diff/1/ HACKING. rst
File HACKING.rst (right):
https:/ /codereview. appspot. com/189580044/ diff/1/ HACKING. rst#newcode356
HACKING.rst:356: parsing ``tox.ini``, dependencies must be listed with
the following rules:
Could you try to re-word that sentence? I'm not sure what you're saying.
https:/ /codereview. appspot. com/189580044/ diff/1/ HACKING. rst#newcode358
HACKING.rst:358: - each scenario must at least include a
"{[testenv]deps}" line in its deps:
Change the : to ; or ,
https:/ /codereview. appspot. com/189580044/ diff/1/ MANIFEST. in
File MANIFEST.in (right):
https:/ /codereview. appspot. com/189580044/ diff/1/ MANIFEST. in#newcode24
MANIFEST.in:24: # tox.ini file, removing it from this list will break
the source distribution
Again, this could be worded better.
https:/ /codereview. appspot. com/189580044/ diff/1/ setup.py
File setup.py (right):
https:/ /codereview. appspot. com/189580044/ diff/1/ setup.py# newcode43
setup.py:43: """Return Juju Quickstart package data by walking through
the project."""
A better explanation of what "package data" is would be nice.
https:/ /codereview. appspot. com/189580044/ diff/1/ setup.py# newcode74
setup.py:74: for requirement in deps:
Maybe add
requirement = requirement.strip()
https:/ /codereview. appspot. com/189580044/ diff/1/ tox.ini
File tox.ini (right):
https:/ /codereview. appspot. com/189580044/ diff/1/ tox.ini# newcode42
tox.ini:42: basepython = python2.7
Is it required to repeat here?
https:/ /codereview. appspot. com/189580044/