Code review comment for lp:~frankban/juju-gui/quickstart-real-bootstrap

Revision history for this message
Francesco Banconi (frankban) wrote :

Reviewers: mp+191410_code.launchpad.net,

Message:
Please take a look.

Description:
Bootstrap the Juju environment.

Wait until the API server is ready.
Retrieve the API address.

Also added --debug support (logging).

Tests: `make check`.

QA: assuming you have a local provider env
named 'local' and an ec2 one named 'ec2'

- run `.venv/bin/python juju-quickstart -e local`
   -> error: the local provider is not currently supported;
- run `.venv/bin/python juju-quickstart -e no-such-env`
   -> error: environment no-such-env not found in ...;
- run `juju switch ec2`;
- run `.venv/bin/python juju-quickstart --debug`
   -> the debug messages are shown, the env is bootstrapped,
      the API URL is printed at the end of the process.
- run `.venv/bin/python juju-quickstart`
   -? like above but this time no debug messages are shown.

https://code.launchpad.net/~frankban/juju-gui/quickstart-real-bootstrap/+merge/191410

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/14441074/

Affected files (+371, -33 lines):
   A [revision details]
   M quickstart/app.py
   M quickstart/manage.py
   M quickstart/tests/helpers.py
   M quickstart/tests/test_app.py
   M quickstart/tests/test_manage.py
   M quickstart/tests/test_utils.py
   M quickstart/utils.py

« Back to merge proposal