Code review comment for lp:~frankban/juju-gui/quickstart-bootstrap

Revision history for this message
Francesco Banconi (frankban) wrote :

Reviewers: mp+191234_code.launchpad.net,

Message:
Please take a look.

Description:
Parse and validate the environment file/options.

Check if the given environment name exists,
ensure it does not use the local provider,
ensure it includes an admin-secret,
retrieve the admin-secret.

Tests: make check

https://code.launchpad.net/~frankban/juju-gui/quickstart-bootstrap/+merge/191234

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/14669047/

Affected files (+633, -17 lines):
   M Makefile
   A [revision details]
   M juju-quickstart
   A quickstart/app.py
   M quickstart/manage.py
   A quickstart/tests/helpers.py
   A quickstart/tests/test_app.py
   M quickstart/tests/test_manage.py
   A quickstart/tests/test_utils.py
   A quickstart/utils.py

« Back to merge proposal