Code review comment for lp:~frankban/juju-gui/preserve-zoom

Revision history for this message
Kapil Thangavelu (hazmat) wrote :

The dbl click causing zoom, is actually a nice effect that would be nice to
preserve as a transition .. Transient though without perm zoom changes.
Part of the feel of going into a svc details is meant to be zoom into focus
on this service.

On Wednesday, October 17, 2012, Francesco Banconi wrote:

> Thanks Ben.
>
>
> https://codereview.appspot.com/6720048/diff/4001/app/views/environment.js
> File app/views/environment.js (right):
>
>
> https://codereview.appspot.com/6720048/diff/4001/app/views/environment.js#newcode243
> app/views/environment.js:243: if (sourceEvent.type === 'dblclick' &&
> On 2012/10/17 14:35:11, benjamin.saller wrote:
> > .on("dblclick.zoom", null) during the bind will remove the dblclick
> behavior.
>
> Done.
>
> https://codereview.appspot.com/6720048/
>
> --
> https://code.launchpad.net/~frankban/juju-gui/preserve-zoom/+merge/130087
> Your team Juju GUI Hackers is requested to review the proposed merge of
> lp:~frankban/juju-gui/preserve-zoom into lp:juju-gui.
>

« Back to merge proposal