Code review comment for lp:~frankban/juju-gui/bug-1169973-dying-services

Revision history for this message
Francesco Banconi (frankban) wrote :

*** Submitted:

Do not hide dying services in an error state

Due to bug 1168154, removing a service in an error state
does not really destroy the service, that will be
eventually destroyed once all its units are resolved.
A dying unit could also fail executing the stop hook,
leaving the service undead in the juju database.
For this reason, we don't wont to hide services in an
erro state, even if they are dying.

QA:
- deploy buildbot-master;
- destroy it;
- wait a second, you should see it return like a
   red zombie.

R=gary.poster, teknico
CC=
https://codereview.appspot.com/8835043

https://codereview.appspot.com/8835043/diff/1/test/test_model.js
File test/test_model.js (right):

https://codereview.appspot.com/8835043/diff/1/test/test_model.js#newcode689
test/test_model.js:689: it('instances identify if they they have
errors', function() {
On 2013/04/18 09:04:02, teknico wrote:
> Double "they".

Done.

https://codereview.appspot.com/8835043/diff/1/test/test_model.js#newcode693
test/test_model.js:693: it('instances identify if they they do not have
errors', function() {
On 2013/04/18 09:04:02, teknico wrote:
> Double "they".

Done.

https://codereview.appspot.com/8835043/

« Back to merge proposal