Code review comment for lp:~frankban/juju-gui/bug-1169858-life

*** Submitted:

Handle service life

The Life change included in the juju-core delta stream is
now stored in the service model, and used to avoid displaying
dying services in the topology view.

QA:

- bootstrap a juju-core env;
- deploy a service;
- connect the GUI to the env;
- use the GUI to destroy the service;
- suddenly refresh (or visit the GUI from another browser tab).

At this point, even if the service could be still
present in the db, it should not be alive and you should
not see it in the topology view.

R=benji, gary.poster
CC=
https://codereview.appspot.com/8824044

https://codereview.appspot.com/8824044/diff/1/app/models/models.js
File app/models/models.js (right):

https://codereview.appspot.com/8824044/diff/1/app/models/models.js#newcode99
app/models/models.js:99: Return true if this service life is "alive",
false otherwise.
On 2013/04/17 12:37:59, benji wrote:
> It might be nice to explain (ether here or in "alive" below) what it
means for a
> service to be "alive".

Done.

https://codereview.appspot.com/8824044/diff/1/test/test_model.js
File test/test_model.js (right):

https://codereview.appspot.com/8824044/diff/1/test/test_model.js#newcode665
test/test_model.js:665: it('instances identify if they are alive',
function() {
On 2013/04/17 12:54:26, gary.poster wrote:
> (and also verifies that the default state is alive :-) )

Indeed! Added a comment.

https://codereview.appspot.com/8824044/