Code review comment for lp:~frankban/juju-gui/bug-1090046-resize

Revision history for this message
Francesco Banconi (frankban) wrote :

*** Submitted:

Fix GUI breakage on browser resizing.

Fixed how yui events are handled by the component framework.
Also added two tests:
- ensure that the module synthetic events binding works;
- ensure that the custom events 'beforePageSizeRecalculation'
   and 'afterPageSizeRecalculation' are correctly fired by
   the environment view when the browser is resized.

QA: resize the browser, open the charm panel, resize the
     browser again, close the charm panel, resize again,
     re-open the panel...

R=benjamin.saller, gary.poster
CC=
https://codereview.appspot.com/6941053

https://codereview.appspot.com/6941053/

« Back to merge proposal