Thanks,
This is a nice catch, a good fix and glad to see the additional tests.
+1 LGTM
https://codereview.appspot.com/6941053/diff/1/app/assets/javascripts/d3-components.js File app/assets/javascripts/d3-components.js (right):
https://codereview.appspot.com/6941053/diff/1/app/assets/javascripts/d3-components.js#newcode238 app/assets/javascripts/d3-components.js:238: var callback = Y.bind(handler.callback, handler.context); This is a nice fix, thank you.
https://codereview.appspot.com/6941053/
« Back to merge proposal
Thanks,
This is a nice catch, a good fix and glad to see the additional tests.
+1 LGTM
https:/ /codereview. appspot. com/6941053/ diff/1/ app/assets/ javascripts/ d3-components. js javascripts/ d3-components. js (right):
File app/assets/
https:/ /codereview. appspot. com/6941053/ diff/1/ app/assets/ javascripts/ d3-components. js#newcode238 javascripts/ d3-components. js:238: var callback = handler. callback, handler.context);
app/assets/
Y.bind(
This is a nice fix, thank you.
https:/ /codereview. appspot. com/6941053/