Thanks for the review Thiago! A reply to your comment follows.
https://codereview.appspot.com/6851058/diff/1/app/views/notifications.js File app/views/notifications.js (right):
https://codereview.appspot.com/6851058/diff/1/app/views/notifications.js#newcode50 app/views/notifications.js:50: if (notifierBox && On 2012/11/16 14:39:29, thiago wrote: > I think will you always have the 'notifier-box' element. It is hard-coded in > index.html. So probably you can remove this check.
The check is here to make tests work. The element is not present in the test page, and it's created by tests' setUp and tearDown only when needed, so that notifications are not created as side effects by non-relevant test cases.
https://codereview.appspot.com/6851058/
« Back to merge proposal
Thanks for the review Thiago! A reply to your comment follows.
https:/ /codereview. appspot. com/6851058/ diff/1/ app/views/ notifications. js notifications. js (right):
File app/views/
https:/ /codereview. appspot. com/6851058/ diff/1/ app/views/ notifications. js#newcode50 notifications. js:50: if (notifierBox &&
app/views/
On 2012/11/16 14:39:29, thiago wrote:
> I think will you always have the 'notifier-box' element. It is
hard-coded in
> index.html. So probably you can remove this check.
The check is here to make tests work. The element is not present in the
test page, and it's created by tests' setUp and tearDown only when
needed, so that notifications are not created as side effects by
non-relevant test cases.
https:/ /codereview. appspot. com/6851058/