https://codereview.appspot.com/6819098/diff/1/lib/views/stylesheet.less#newcode850
lib/views/stylesheet.less:850: border-bottom: 1px solid #C2C2C2;
Where did these colors come from? They don't seem to match the ones in
the assets provided (charm_head2_div.png, charm_detail_title_div.png,
etc). They do *look* really good, though.
https://codereview.appspot.com/6819098/diff/1/lib/views/stylesheet.less#newcode871
lib/views/stylesheet.less:871: border-bottom: 1px solid #C2C2C2;
It would be nice to abstract these re-used colors, if possible in a
readable manner. I cannot believe we have so many different shades of
gray in this stylesheet, but that's what has been specified.
Nice branch Francesco. I've made a few comments but nothing serious.
I do think the configuration file stuff needs to be fixed or possibly
deferred to another branch.
https:/ /codereview. appspot. com/6819098/ diff/1/ app/templates/ charm-descripti on.handlebars charm-descripti on.handlebars (right):
File app/templates/
https:/ /codereview. appspot. com/6819098/ diff/1/ app/templates/ charm-descripti on.handlebars# newcode2 charm-descripti on.handlebars: 2: <div charm-nav- back">< i class=" icon-chevron- left">< /i> Back</div>
app/templates/
class="
Why not use the new asset in this branch?
https:/ /codereview. appspot. com/6819098/ diff/1/ app/templates/ charm-pre- configuration. handlebars charm-pre- configuration. handlebars (right):
File app/templates/
https:/ /codereview. appspot. com/6819098/ diff/1/ app/templates/ charm-pre- configuration. handlebars# newcode50 charm-pre- configuration. handlebars: 50:
app/templates/
When selecting a configuration file, the name now overlaps with other
elements. This work probably should be a separate branch.
https:/ /codereview. appspot. com/6819098/ diff/1/ lib/views/ stylesheet. less stylesheet. less (right):
File lib/views/
https:/ /codereview. appspot. com/6819098/ diff/1/ lib/views/ stylesheet. less#newcode850 stylesheet. less:850: border-bottom: 1px solid #C2C2C2; head2_div. png, charm_detail_ title_div. png,
lib/views/
Where did these colors come from? They don't seem to match the ones in
the assets provided (charm_
etc). They do *look* really good, though.
https:/ /codereview. appspot. com/6819098/ diff/1/ lib/views/ stylesheet. less#newcode871 stylesheet. less:871: border-bottom: 1px solid #C2C2C2;
lib/views/
It would be nice to abstract these re-used colors, if possible in a
readable manner. I cannot believe we have so many different shades of
gray in this stylesheet, but that's what has been specified.
https:/ /codereview. appspot. com/6819098/ diff/1/ test/test_ charm_panel. js charm_panel. js (right):
File test/test_
https:/ /codereview. appspot. com/6819098/ diff/1/ test/test_ charm_panel. js#newcode234 charm_panel. js:234: div.get( 'text') .should. contain( 'A DB');
test/test_
description_
Nice simplification.
https:/ /codereview. appspot. com/6819098/