Code review comment for lp:~frankban/juju-core/env-name-in-context

Revision history for this message
Francesco Banconi (frankban) wrote :

Reviewers: mp+204450_code.launchpad.net,

Message:
Please take a look.

Description:
Add the environment name to the hooks context.

Expose the human friendly environment name to the
hooks through the JUJU_ENV_NAME environment variable.

This is required e.g. by the GUI in order to give to the user
a hint about where to find the password to log in.

https://code.launchpad.net/~frankban/juju-core/env-name-in-context/+merge/204450

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/50090044/

Affected files (+113, -38 lines):
   A [revision details]
   M doc/charms-in-action.txt
   M state/api/params/internal.go
   M state/api/uniter/environ.go
   M state/api/uniter/environ_test.go
   M state/api/uniter/uniter.go
   M state/apiserver/uniter/uniter.go
   M state/apiserver/uniter/uniter_test.go
   M state/environ.go
   M state/environ_test.go
   M worker/uniter/context.go
   M worker/uniter/context_test.go
   M worker/uniter/uniter.go

« Back to merge proposal