Code review comment for lp:~frankban/juju-core/bug-1147138-annotations-api

Revision history for this message
Francesco Banconi (frankban) wrote :

Reviewers: mp+152037_code.launchpad.net,

Message:
Please take a look.

Description:
Annotations API functionality

Annotations are now exposed through the API via 'GetAnnotations' and
'SetAnnotation'. These allow a user to set an annotation on an Entity
(service,
'unit', 'machine', with environment coming in a future branch), and
retrieve
all annotations on an entity. Tests were added around the added
functionality.
Note that now the service is an Entity, as suggested by Roger.

https://code.launchpad.net/~frankban/juju-core/bug-1147138-annotations-api/+merge/152037

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/7526043/

Affected files:
   A [revision details]
   M state/api/apiclient.go
   M state/apiserver/api_test.go
   M state/apiserver/apiserver.go
   M state/machine_test.go
   M state/service.go
   M state/service_test.go
   M state/state.go
   M state/state_test.go
   M state/unit_test.go
   M state/user.go
   M state/user_test.go

« Back to merge proposal