Merge lp:~frankban/charms/trusty/juju-gui/fix-branch-ftest into lp:~juju-gui/charms/trusty/juju-gui/trunk

Proposed by Francesco Banconi
Status: Merged
Merged at revision: 210
Proposed branch: lp:~frankban/charms/trusty/juju-gui/fix-branch-ftest
Merge into: lp:~juju-gui/charms/trusty/juju-gui/trunk
Diff against target: 13 lines (+3/-0)
1 file modified
tests/20-functional.test (+3/-0)
To merge this branch: bzr merge lp:~frankban/charms/trusty/juju-gui/fix-branch-ftest
Reviewer Review Type Date Requested Status
Juju GUI Hackers Pending
Review via email: mp+238400@code.launchpad.net

Description of the change

Fix branch functional test.

Skip the test on precise.

https://codereview.appspot.com/160890043/

To post a comment you must log in.
Revision history for this message
Francesco Banconi (frankban) wrote :

Reviewers: mp+238400_code.launchpad.net,

Message:
Please take a look.

Description:
Fix branch functional test.

Skip the test on precise.

https://code.launchpad.net/~frankban/charms/trusty/juju-gui/fix-branch-ftest/+merge/238400

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/160890043/

Affected files (+5, -0 lines):
   A [revision details]
   M tests/20-functional.test

Index: [revision details]
=== added file '[revision details]'
--- [revision details] 2012-01-01 00:00:00 +0000
+++ [revision details] 2012-01-01 00:00:00 +0000
@@ -0,0 +1,2 @@
+Old revision:
<email address hidden>
+New revision:
<email address hidden>

Index: tests/20-functional.test
=== modified file 'tests/20-functional.test'
--- tests/20-functional.test 2014-09-12 11:23:44 +0000
+++ tests/20-functional.test 2014-10-15 07:49:26 +0000
@@ -202,6 +202,9 @@
          server_info = self.get_builtin_server_info(hostname)
          self.assertTrue(server_info['sandbox'])

+ @unittest.skipIf(
+ bootstrap_node_series == 'precise',
+ 'deploying from git branches is not supported on precise')
      def test_branch_source(self):
          # Ensure the Juju GUI is correctly deployed from a Git branch.
          options = {'juju-gui-source': JUJU_GUI_TEST_BRANCH}

Revision history for this message
Francesco Banconi (frankban) wrote :
Revision history for this message
Francesco Banconi (frankban) wrote :

*** Submitted:

Fix branch functional test.

Skip the test on precise.

R=
CC=
https://codereview.appspot.com/160890043

https://codereview.appspot.com/160890043/

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tests/20-functional.test'
2--- tests/20-functional.test 2014-09-12 11:23:44 +0000
3+++ tests/20-functional.test 2014-10-15 08:29:22 +0000
4@@ -202,6 +202,9 @@
5 server_info = self.get_builtin_server_info(hostname)
6 self.assertTrue(server_info['sandbox'])
7
8+ @unittest.skipIf(
9+ bootstrap_node_series == 'precise',
10+ 'deploying from git branches is not supported on precise')
11 def test_branch_source(self):
12 # Ensure the Juju GUI is correctly deployed from a Git branch.
13 options = {'juju-gui-source': JUJU_GUI_TEST_BRANCH}

Subscribers

People subscribed via source and target branches