Code review comment for lp:~frankban/charms/precise/juju-gui/support-firewall
Revision history for this message
| Francesco Banconi (frankban) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
(Get the code!)
*** Submitted:
Avoid installing from PPA if not required.
No longer add the juju-gui PPA by default:
the external repository is added only if required,
i.e. if the legacy server is used or if a branch
is passed to juju-gui-source.
The only missing bit to make the charm work well
from behind a firewall AFAICT is avoiding the release
to be downloaded from Launchpad.
Also included the shelltoolbox file in the charm:
unfortunately the python-shelltoolbox package is
not available on precise. On the other hand, this
allows for getting rid of the bootstrap_utils.py
file, and the install hook now feels cleaner.
Refactoring + some magic removal on the backend
framework. Now it should be less surprising, and
also allows for more customizations, e.g. what
I did in the install method.
Also added missing tests for the backend framework:
those were required in order to increase our control
over what's really happening in the backend "hooks".
Switched to the builtin Tornado server by default.
This diff is very big, I am sorry, but:
- you can ignore the bootstrap_utils removal;
- you can ignore the shelltoolbox.py file: it is
just a copy of the one present in the raring
python-
- a lot of code is tests, the rest of the code
should be quite easy to follow.
QA:
`make deploy` and watch the logs:
- no PPA should be installed by default;
- the deployment succeeds and the GUI works well;
switch to builtin-
- the PPA is installed (and then haproxy, apache...);
- the config-change hook exits without errors and
the GUI works well.
Tests:
`make unittest`
(I ran the functional tests myself).
Thank you!
R=gary.poster, rharding
CC=
https:/
https:/
File hooks/backend.py (right):
https:/
hooks/backend.
On 2013/10/07 17:01:08, gary.poster wrote:
> Does this belong somewhere else now? Or can it be deleted?
Yeah, I was curious about that dependency too. I found that curl is used
by fetch_gui_release to download a release tarball from Launchpad. So,
formally it belongs here: added a comment describing what curl is used
for.
https:/
hooks/backend.
reversed list of objects.
On 2013/10/07 17:01:08, gary.poster wrote:
> Delete this line? (functionality is gone)
Done thank you, and yes, my first implementation included that kwarg,
but then I realized it was unnecessary.
https:/
hooks/backend.
On 2013/10/07 17:01:08, gary.poster wrote:
> A subtle thing, but any one of these would read a bit better to me, as
ranked
> from my personal highest to lowest preference.
> Execute the charm's "start" steps.
> Execute the charm's starting steps.
> Execute the charm-starting steps.
Done.
https:/
hooks/backend.
On 2013/10/07 17:01:08, gary.poster wrote:
> Perhaps the following?
> ----
> Execute the charm's "stop" steps.
> Iterates through the mixins in reverse order.
Done.
https:/
hooks/backend.
On 2013/10/07 17:01:08, gary.poster wrote:
> WDYT?
> ---
> Execute the charm removal steps.
> Iterates through the mixins in reverse order.
Done.
https:/
File hooks/shelltool
https:/
hooks/shelltool
On 2013/10/07 17:01:08, gary.poster wrote:
> I included comments about the source in hooks/charmhelp
what I did
> there. If you like it, include it here; otherwise, feel free to
ignore it.
Good idea, done.
https:/