Code review comment for lp:~frankban/charms/precise/juju-gui/guiserver-views
Revision history for this message
| Francesco Banconi (frankban) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
(Get the code!)
*** Submitted:
Bundle deployment views.
This branch includes the implementation of the
bundle views. Their goal is to handle the bundle
deployment request/response process.
Views interact with the Deployer instance
(not yet implemented) in order to schedule,
run and observe bundle deployments.
R=bac, benji
CC=
https:/
https:/
File server/
https:/
server/
access: unknown user')
On 2013/08/20 13:24:09, bac wrote:
> The error message is a little misleading. "unknown user" implies we
have a user
> but don't recognize her when in fact there is no logged in user.
> How about:
> error='unauthorized access: no user logged in.' ?
You are right, changed the message.
https:/
File server/
https:/
server/
On 2013/08/20 13:24:09, bac wrote:
> s/creating this kind of responses/create these responses
Done.
https:/
server/
fixed switching to a newer version of Python).
On 2013/08/20 13:28:10, benji wrote:
> I was wondering about why we didn't use Python 3 for this server. Is
there a
> Tornado requirement for Python 2?
No, Tornado is fully compatible with Python3. And I guess it should be
quite easy to port the GUI server to Python3. The problem here is that
juju-deployer only supports Python2, and therefore, for now, we cannot
upgrade.
https:/
server/
unseen changes are available, a response is
On 2013/08/20 13:28:10, benji wrote:
> "unsent" might be slightly clearer than "unseen".
Done.
https:/
server/
changes. Otherwise, this views suspends
On 2013/08/20 13:28:10, benji wrote:
> I think "immediately" would be a bit better than "suddenly".
Done.
https:/
server/
request: invalid data parameters')
On 2013/08/20 13:24:09, bac wrote:
> Perhaps list the params in the error message?
Done.
https:/