Code review comment for lp:~frankban/charms/precise/juju-gui/guiserver-auth-fixes

Revision history for this message
Francesco Banconi (frankban) wrote :

Reviewers: mp+179014_code.launchpad.net,

Message:
Please take a look.

Description:
Authentication fixes.

Fixed an error in the guiserver authentication
when the request id is set to 0.

Moved the auth_backend from the app to the
handler: it is only relevant in the WebSocketHandler
context.

Some clean up in the tests.

https://code.launchpad.net/~frankban/charms/precise/juju-gui/guiserver-auth-fixes/+merge/179014

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/12612043/

Affected files:
   A [revision details]
   M server/guiserver/apps.py
   M server/guiserver/auth.py
   M server/guiserver/handlers.py
   M server/guiserver/tests/test_apps.py
   M server/guiserver/tests/test_auth.py
   M server/guiserver/tests/test_handlers.py
   M server/guiserver/tests/test_manage.py

« Back to merge proposal