Juju Charms Collection
juju-gui package

Code review comment for lp:~frankban/charms/precise/juju-gui/cancel-deployment

  1. Precise Pangolin (12.04)
  2. cancel-deployment
  3. Merge into trunk
Revision history for this message
Francesco Banconi (frankban) wrote :

On 2013/09/13 13:45:00, rharding wrote:
> LGTM

> Results of the script, first run:

> http://paste.mitechie.com/show/1020/

Great, thank you for QAing this branch!

> I did run it a second time and got an error:

> http://paste.mitechie.com/show/1021/

> I'm not sure if this is a bug here or as a follow up to not crash when
the
> service is already there.

Running the script a second time you also tested the validation
step failing when there is a service name clash in the
environment, and that's the correct behavior.
The subsequent KeyError is ok since the script expects
the request to be successful.

Thanks!

https://codereview.appspot.com/13549046/

« Back to merge proposal