Code review comment for lp:~frankban/charms/precise/juju-gui/cancel-deployment

Revision history for this message
Francesco Banconi (frankban) wrote :

On 2013/09/13 13:16:21, rharding wrote:

> server/guiserver/bundles/views.py:182: deployment_id =
> request.params.get('DeploymentId')
> caps in the query string? why not match the var name used
deployment_id?

params is not really a querystring, it's the content of the Params field
included in the WebSocket message. Caps are used for consistency with
all
the other juju-core API calls.

https://codereview.appspot.com/13549046/

« Back to merge proposal