Juju Charms Collection
juju-gui package

Code review comment for lp:~frankban/charms/precise/juju-gui/cancel-deployment

  1. Precise Pangolin (12.04)
  2. cancel-deployment
  3. Merge into trunk
Revision history for this message
Richard Harding (rharding) wrote :

code ok, will qa next. Just have the one objection to camel cased http
params.

https://codereview.appspot.com/13549046/diff/1/server/guiserver/bundles/views.py
File server/guiserver/bundles/views.py (right):

https://codereview.appspot.com/13549046/diff/1/server/guiserver/bundles/views.py#newcode182
server/guiserver/bundles/views.py:182: deployment_id =
request.params.get('DeploymentId')
caps in the query string? why not match the var name used deployment_id?

https://codereview.appspot.com/13549046/

« Back to merge proposal