lp:~frankban/charms/precise/juju-gui/bug-1103035-charm-fixes

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:~juju-gui/charms/precise/juju-gui/trunk at revision 29

Juju GUI Hackers: Pending requested 2013-01-23

Diff: 262 lines (+32/-85)

9 files modified

README.md (+18/-6)
config.yaml (+0/-14)
hooks/config-changed (+4/-6)
hooks/install (+1/-1)
hooks/start (+3/-3)
hooks/utils.py (+3/-18)
metadata.yaml (+1/-1)
revision (+1/-1)
tests/test_utils.py (+1/-35)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

32. By Francesco Banconi on 2013-01-23

Bump revision up.

31. By Francesco Banconi on 2013-01-23

Get rid of user and password configuration options.

30. By Francesco Banconi on 2013-01-23

Added curl to deb dependencies.

29. By Francesco Banconi on 2013-01-23

Fixes to documentation as per review.

28. By Francesco Banconi on 2013-01-22

Fix "file not found" error.

If the last stable release does not contain
a file, deploying a charm failed with a
"file not found" error. We encounter this
problem, e.g., while uploading a new release:
the release is created in Launchpad, but the
file takes a bit before being ready.
Now the relevant function tries previous
releases before failing.
Also fixed a functional test failing because
now staging does not require explicit
authentication (user and password are
provided by the config file).

R=bac, teknico
CC=
https://codereview.appspot.com/7177049

27. By Francesco Banconi on 2013-01-21

Fix charm according to "charm proof"

Add copyright file and maintainer, and remove "juju" key.
Landing Gary's branch.

R=
CC=
https://codereview.appspot.com/7182044

26. By Francesco Banconi on 2013-01-17

User, password and read-only options.

This branch adds three more options to
the charm. If staging is true, user and
password options are ignored, and the
authentication is automatically handled
by the charm, providing staging pre-defined
values.

R=
CC=
https://codereview.appspot.com/7127048

25. By Francesco Banconi on 2013-01-11

Juju GUI source as env var + Charm test branch

This branch introduces the possibility to provide
the Juju GUI source (used in tests) by setting an
environment variable. This way the charm tests can
be run as part of the release qa process, e.g.:

$ JUJU_GUI_SOURCE=lp:mybranch jitsu test juju-gui ...

or, to test a new trunk release:

$ JUJU_GUI_SOURCE=trunk jitsu test juju-gui ...

Also updated the test exercising the process of
making a release from a branch, i.e. when the
juju-gui-source option points to a Bazaar branch.

Now the branch used is a customized one, present in
`lp:~frankban/juju-gui/charm-tests-branch` (please
feel free to suggest another, more sane, location,
and please take a look at that as part of your reviews).
This is a test branch containing only a minimal
Makefile and a release tarball. There, `make distfile`
is almost a no-op, and for this reason the charm test
speed is slightly increased (~4 minutes on ec2).
Source: http://bazaar.launchpad.net/~frankban/juju-gui/charm-tests-branch/files

R=gary.poster, teknico
CC=
https://codereview.appspot.com/7102044

24. By Nicola Larosa on 2013-01-11

Update the README and HACKING docs

Update the README.md and HACKING.md docs to reflect the current
status. Add to the former a section and link to the demo/staging
server (https://uistage.jujucharms.com:8080/).

R=gary.poster, frankban
CC=
https://codereview.appspot.com/7103043

23. By Francesco Banconi on 2013-01-11

Implemented Selenium tests and login-help.

This branch introduces integration tests based
on Selenium. This way it is possible to check that
the GUI actually works, is connected to the API
backend, etc.

Firefox is the webdriver used here, it is installed
by default in Ubuntu. All the graphical operations
are executed in memory thanks to xvfbwrapper.

This branch also includes the changes Gary made to
add a charm option for the login help text.

R=gary.poster, teknico
CC=
https://codereview.appspot.com/7064068