https://codereview.appspot.com/6977043/diff/8001/hooks/config-changed#newcode50
hooks/config-changed:50: # Restarting of the gui and api services is
handled below.
gary.poster wrote:
> I think the point of the comment is to reassure readers that these
things
> will be restarted, just not in this code block. "below" means "not in
> this code block."
Oh, I see. I mistook "below" to mean "in the code below, within this
function".
> The comment worked for me. Would this have been clearer for you?
> "# The juju_gui_source_changed and juju_api_branch_changed variables
> control whether we restart the GUI and the API, respectively, at the
end
> of the function." Or something. Other ideas?
Yes, maybe with s/at the end of the function./after this function./, or
similar.
frankban wrote:
> This pre-existed and I think it's actually correct, the services are
not
> restarted here.
Yes, it preexisted, but it was placed *after* a code block, making its
interpretation less ambiguous.
https:/ /codereview. appspot. com/6977043/ diff/8001/ hooks/config- changed changed (right):
File hooks/config-
https:/ /codereview. appspot. com/6977043/ diff/8001/ hooks/config- changed# newcode50 changed: 50: # Restarting of the gui and api services is
hooks/config-
handled below.
gary.poster wrote:
> I think the point of the comment is to reassure readers that these
things
> will be restarted, just not in this code block. "below" means "not in
> this code block."
Oh, I see. I mistook "below" to mean "in the code below, within this
function".
> The comment worked for me. Would this have been clearer for you? source_ changed and juju_api_ branch_ changed variables
> "# The juju_gui_
> control whether we restart the GUI and the API, respectively, at the
end
> of the function." Or something. Other ideas?
Yes, maybe with s/at the end of the function./after this function./, or
similar.
frankban wrote:
> This pre-existed and I think it's actually correct, the services are
not
> restarted here.
Yes, it preexisted, but it was placed *after* a code block, making its
interpretation less ambiguous.
https:/ /codereview. appspot. com/6977043/