Code review comment for lp:~fpstovall/nrtb/cpp_common

Revision history for this message
Aron Boyette (aron-carolina) wrote :

I'm still going to review out it. Are you available Tuesday to discuss
findings?
On Sep 4, 2011 8:33 PM, "Rick Stovall" <email address hidden> wrote:
> Review: Approve merge test
> I conducted a test merge into a copy of the alpha branch. The merge
completed automatically with no manual overrides required. I reviewed the
change list and found only the expected changes. I then went to the common
directory and ran make, piping the build and unit test output to a file.
Careful review of the file showed all builds and all unit tests completed
successfully.
>
> In the absence of other reviews, this will constitute sufficient review
and approval to merge the cpp_common branch into the alpha main branch.
> --
> https://code.launchpad.net/~fpstovall/nrtb/cpp_common/+merge/72827
> You are requested to review the proposed merge of
lp:~fpstovall/nrtb/cpp_common into lp:nrtb.

« Back to merge proposal