Merge lp:~fourdollars/ubiquity/xenial-proposed into lp:~ubuntu-installer/ubiquity/xenial-proposed

Proposed by Shih-Yuan Lee on 2018-01-31
Status: Needs review
Proposed branch: lp:~fourdollars/ubiquity/xenial-proposed
Merge into: lp:~ubuntu-installer/ubiquity/xenial-proposed
Diff against target: 37 lines (+11/-1)
2 files modified
debian/changelog (+6/-0)
scripts/plugininstall.py (+5/-1)
To merge this branch: bzr merge lp:~fourdollars/ubiquity/xenial-proposed
Reviewer Review Type Date Requested Status
Ubuntu Installer Team 2018-01-31 Pending
Review via email: mp+336893@code.launchpad.net
To post a comment you must log in.
Rik Shaw (rik-shaw) wrote :

Is there any update on this update getting approved for xenial-proposed?

I just was tracking down strange behavior with crashes in ubiquity related to locale settings and I have confirmed this patch solves the issues (by manually applying the patch to the casper live system before running ubiquity).

Thanks for the work in solving this crash, now I am trying to understand how I can apply it to xenial for our re-spin installers (possibly similar to fourdollars mention of the dell-installer having issues and needing this patch)

Unmerged revisions

6457. By Shih-Yuan Lee on 2018-01-31

Ensure the IO encoding for Debconf always to be utf-8. (LP: #1713002)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2017-10-31 17:45:34 +0000
3+++ debian/changelog 2018-01-31 07:06:43 +0000
4@@ -1,3 +1,9 @@
5+ubiquity (2.21.63.6) UNRELEASED; urgency=medium
6+
7+ * Ensure the IO encoding for Debconf always to be utf-8. (LP: #1713002)
8+
9+ -- Shih-Yuan Lee (FourDollars) <sylee@ubuntu.com> Wed, 31 Jan 2018 15:02:07 +0800
10+
11 ubiquity (2.21.63.5) xenial; urgency=medium
12
13 * Cherry-pick support for WPA2 Enterprise. LP: #1107935
14
15=== modified file 'scripts/plugininstall.py'
16--- scripts/plugininstall.py 2016-03-21 19:30:58 +0000
17+++ scripts/plugininstall.py 2018-01-31 07:06:43 +0000
18@@ -23,6 +23,7 @@
19
20 import fcntl
21 import gzip
22+import io
23 import os
24 import platform
25 import pwd
26@@ -105,7 +106,10 @@
27 def __init__(self):
28 install_misc.InstallBase.__init__(self)
29
30- self.db = debconf.Debconf()
31+ self.db = debconf.Debconf(
32+ read=io.TextIOWrapper(sys.stdin.buffer, encoding='utf-8'),
33+ write=io.TextIOWrapper(sys.stdout.buffer, encoding='utf-8'))
34+
35 self.kernel_version = platform.release()
36
37 # Get langpacks from install

Subscribers

People subscribed via source and target branches