Merge lp:~fourdollars/ubiquity/trunk into lp:ubiquity

[Shih-Yuan Lee]

[Mathieu Trudel-Lapierre (cyphermox)]

Looks reasonable, but are you certain this is the right place for that particular fix? Have you tested this?

There are multiple other calls to Debconf() elsewhere, some others may be affected the same way, or be required to properly fix the issue you're seeing.

In general, I think this is a good idea, and should probably be applied everywhere, but I want to make sure it doesn't break things, so I'd land this on its own.

review: Needs Information

[Shih-Yuan Lee (fourdollars)]

I have used this on Ubuntu OEM project for Dell and it does fix the problem.
I don't see any possibility that it may break any Debconf call because Deconf uses UTF-8 by default.

[Yuan-Chen Cheng (ycheng-twn)]

change the status to re-submit for Shih-Yuan.

review: Needs Resubmitting

[Mathieu Trudel-Lapierre (cyphermox)]

Looks good.

review: Approve

=== modified file 'scripts/plugininstall.py'
--- scripts/plugininstall.py	2017-07-18 15:21:41 +0000
+++ scripts/plugininstall.py	2017-08-25 08:59:39 +0000
@@ -22,6 +22,7 @@
 from __future__ import print_function
 
 import gzip
+import io
 import os
 import platform
 import pwd
@@ -87,7 +88,10 @@
     def __init__(self):
         install_misc.InstallBase.__init__(self)
 
-        self.db = debconf.Debconf()
+        self.db = debconf.Debconf(
+            read=io.TextIOWrapper(sys.stdin.buffer, encoding='utf-8'),
+            write=io.TextIOWrapper(sys.stdout.buffer, encoding='utf-8'))
+
         self.kernel_version = platform.release()
 
         # Get langpacks from install