Merge ~fourdollars/plainbox-provider-checkbox:master into plainbox-provider-checkbox:master

[Shih-Yuan Lee]

[Jonathan Cave (jocave)]

The job looks good to me, thanks! Two comments:

1) A very minor point, but it looks nice if the summary first word is capitalised s/check/Check/
2) Your commit message contains links to trello boards which might be considered an internal tool and so possibly not all that suitable for linking in this public project.

[Shih-Yuan Lee (fourdollars)]

I have revised the commit.
Please help to review it again. Thx.

[Sylvain Pineau (sylvain-pineau)]

Job looks good to me too and indeed it does not take too long to run so it could be a good candidate to run as part of:

https://git.launchpad.net/plainbox-provider-checkbox/tree/units/miscellanea/test-plan.pxu#n21

Moreover debsums is not listed in the LTS manifests, so please create the following packaging meta data unit to add the dependency (in a units/miscellanea/packaging.pxu):

unit: packaging meta-data
os-id: debian
Depends: debsums

review: Needs Fixing

[Shih-Yuan Lee (fourdollars)]

Submitted more commits.
Please help to review it again. Thx.

[Sylvain Pineau (sylvain-pineau)]

LGTM, +1

review: Approve

[Alex Tu (alextu)]

@ sylvain-pineau and FourDollars

Is this the better category that we can add test cases for environment checking? e.g. debsum .. etc ? https://git.launchpad.net/plainbox-provider-checkbox/tree/units/info

I'm a bit confused on units/info and units/miscellanea

review: Needs Information

diff --git a/units/miscellanea/jobs.pxu b/units/miscellanea/jobs.pxu
index 95d781e..59a66b4 100644
--- a/units/miscellanea/jobs.pxu
+++ b/units/miscellanea/jobs.pxu
@@ -460,3 +460,13 @@ id: miscellanea/fan_stress_reaction
 command: fan_reaction_test.py
 _summary: Check if system fans react to CPU load
 _description: Check if system fans react to CPU load
+
+plugin: shell
+category_id: com.canonical.plainbox::miscellanea
+estimated_duration: 60
+id: miscellanea/debsums
+user: root
+requires: package.name == 'debsums'
+command: debsums -c
+_summary: Check the MD5 sums of installed Debian packages
+_description: Verify installed Debian package files against MD5 checksum lists from /var/lib/dpkg/info/*.md5sums.
diff --git a/units/miscellanea/packaging.pxu b/units/miscellanea/packaging.pxu
 new file mode 100644
index 0000000..8c6cc4a
--- /dev/null
+++ b/units/miscellanea/packaging.pxu
@@ -0,0 +1,3 @@
+unit: packaging meta-data
+os-id: debian
+Depends: debsums
diff --git a/units/miscellanea/test-plan.pxu b/units/miscellanea/test-plan.pxu
index 5b23880..40b4d5f 100644
--- a/units/miscellanea/test-plan.pxu
+++ b/units/miscellanea/test-plan.pxu
@@ -33,6 +33,7 @@ include:
     miscellanea/oops                               certification-status=blocker
     miscellanea/oops_results.log
     miscellanea/fan_stress_reaction
+    miscellanea/debsums
 bootstrap_include:
     fwts