Merge ~fourdollars/plainbox-provider-checkbox:master into plainbox-provider-checkbox:master
Proposed by
Shih-Yuan Lee
Status: | Merged |
---|---|
Approved by: | Sylvain Pineau |
Approved revision: | 42ab4a05a6ec7c6d371bf9075f4ca6baaf8931c1 |
Merged at revision: | f27d3bec726b6d5626818dff6ed64e2fc7009848 |
Proposed branch: | ~fourdollars/plainbox-provider-checkbox:master |
Merge into: | plainbox-provider-checkbox:master |
Diff against target: |
38 lines (+14/-0) 3 files modified
units/miscellanea/jobs.pxu (+10/-0) units/miscellanea/packaging.pxu (+3/-0) units/miscellanea/test-plan.pxu (+1/-0) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Alex Tu (community) | Needs Information | ||
Sylvain Pineau | Approve | ||
Review via email: mp+385732@code.launchpad.net |
To post a comment you must log in.
The job looks good to me, thanks! Two comments:
1) A very minor point, but it looks nice if the summary first word is capitalised s/check/Check/
2) Your commit message contains links to trello boards which might be considered an internal tool and so possibly not all that suitable for linking in this public project.