Merge ~fourdollars/pc-enablement/+git/ubuntu-recovery:main into ~oem-solutions-engineers/pc-enablement/+git/ubuntu-recovery:main

Proposed by Shih-Yuan Lee
Status: Merged
Approved by: Shih-Yuan Lee
Approved revision: b69f000c516211afb65b9ea1113cddc4e3081420
Merged at revision: e3505fcb31ddd69e4fbcfa45403f70e878a0d7db
Proposed branch: ~fourdollars/pc-enablement/+git/ubuntu-recovery:main
Merge into: ~oem-solutions-engineers/pc-enablement/+git/ubuntu-recovery:main
Diff against target: 45 lines (+2/-10)
3 files modified
bin/recovery-media-creator (+2/-0)
debian/ubuntu-recovery.postinst (+0/-5)
debian/ubuntu-recovery.templates (+0/-5)
Reviewer Review Type Date Requested Status
Bin Li Approve
Review via email: mp+425219@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Bin Li (binli) wrote :

LGTM.
Thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/bin/recovery-media-creator b/bin/recovery-media-creator
index eb61617..2b6e831 100755
--- a/bin/recovery-media-creator
+++ b/bin/recovery-media-creator
@@ -16,6 +16,8 @@
16# You should have received a copy of the GNU General Public License16# You should have received a copy of the GNU General Public License
17# along with this program. If not, see <http://www.gnu.org/licenses/>.17# along with this program. If not, see <http://www.gnu.org/licenses/>.
1818
19import gi
20gi.require_version('Gtk', '3.0')
19from gi.repository import Gtk, GObject21from gi.repository import Gtk, GObject
20import subprocess, logging, dbus, os22import subprocess, logging, dbus, os
2123
diff --git a/debian/ubuntu-recovery.postinst b/debian/ubuntu-recovery.postinst
index b0cf7bd..3574e18 100644
--- a/debian/ubuntu-recovery.postinst
+++ b/debian/ubuntu-recovery.postinst
@@ -14,11 +14,6 @@ case "$1" in
14 [ "$RET" != "PQSERVICE" -a -e /lib/udev/rules.d/96-ubuntu-recovery-partition.rules ]; then14 [ "$RET" != "PQSERVICE" -a -e /lib/udev/rules.d/96-ubuntu-recovery-partition.rules ]; then
15 sed 's/PQSERVICE/'$RET'/g' -i /lib/udev/rules.d/96-ubuntu-recovery-partition.rules15 sed 's/PQSERVICE/'$RET'/g' -i /lib/udev/rules.d/96-ubuntu-recovery-partition.rules
16 fi16 fi
17
18 if db_get ubuntu-recovery/recovery_media && \
19 [ "$RET" = false -a -e /usr/share/applications/recovery-media-creator.desktop ]; then
20 rm /usr/share/applications/recovery-media-creator.desktop
21 fi
22 ;;17 ;;
2318
24 abort-upgrade|abort-remove|abort-deconfigure)19 abort-upgrade|abort-remove|abort-deconfigure)
diff --git a/debian/ubuntu-recovery.templates b/debian/ubuntu-recovery.templates
index 7d1c088..7978827 100644
--- a/debian/ubuntu-recovery.templates
+++ b/debian/ubuntu-recovery.templates
@@ -47,11 +47,6 @@ Type: string
47Default: 047Default: 0
48Description: for internal use; determines the offset of the recovery partition48Description: for internal use; determines the offset of the recovery partition
4949
50Template: ubuntu-recovery/recovery_media
51Type: boolean
52Default: false
53Description: for internal use; determines the support of creating the recovery media on USB and DVD.
54
55Template: ubuntu-recovery/active_partition50Template: ubuntu-recovery/active_partition
56Type: string51Type: string
57Default: dynamic52Default: dynamic

Subscribers

People subscribed via source and target branches