Merge ~fourdollars/pc-enablement/+git/oem-scripts:master into ~oem-solutions-engineers/pc-enablement/+git/oem-scripts:master

Proposed by Shih-Yuan Lee
Status: Merged
Approved by: Artur Pak
Approved revision: 689ef68d1d439ce6e1f12ae051b4a6bdc51ebbfc
Merged at revision: 7f6873a5c9bc7d0af6d672db97a0ab2cd80adda0
Proposed branch: ~fourdollars/pc-enablement/+git/oem-scripts:master
Merge into: ~oem-solutions-engineers/pc-enablement/+git/oem-scripts:master
Diff against target: 41 lines (+10/-11)
1 file modified
mir-bug (+10/-11)
Reviewer Review Type Date Requested Status
Artur Pak Approve
Review via email: mp+464187@code.launchpad.net

Description of the change

To post a comment you must log in.
Revision history for this message
Artur Pak (artur-at-work) wrote :

LGTM

review: Approve
Revision history for this message
OEM Taipei Bot (oem-taipei-bot) wrote :

[autopkgtest]
pkg-iot-meta PASS
pkg-somerville-meta PASS
pkg-stella-meta PASS
pkg-sutton-meta PASS
bug-bind PASS
get-private-ppa PASS
lp-api PASS
lp-bug PASS
pkg-list PASS
review-merge-proposal PASS
run-autopkgtest PASS
setup-apt-dir PASS
bootstrap-meta FAIL non-zero exit status 1
mir-bug PASS
oem-meta-packages PASS
git-url-insteadof-setting PASS
lp-dl-attm PASS
recovery-from-iso.sh PASS

https://oem-share.canonical.com/partners/lyoncore/share/artifacts/oem-scripts/oem-scripts-2.1-689ef68-in-linux-container-jammy

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/mir-bug b/mir-bug
2index 5d35159..09d3aa1 100755
3--- a/mir-bug
4+++ b/mir-bug
5@@ -890,19 +890,18 @@ def check_and_update_bug_attachments(
6 for attachment in bug.attachments:
7 if "debdiff" in attachment.title:
8 _run_command(["wget", attachment.data_link, "-O", "data"])
9- if sys.stdout.isatty():
10- out, err, returncode = _run_command(
11- ["colordiff", "-ur", "data", debdiff], returncode=(0, 1)
12- )
13- else:
14- out, err, returncode = _run_command(
15- ["diff", "-ur", "data", debdiff], returncode=(0, 1)
16- )
17- if returncode == 1:
18+ out, err, _ = _run_command(["interdiff", "data", debdiff])
19+ if out:
20 warning(
21 f"{attachment.title} - {attachment.web_link} has unexpected content."
22 )
23- info(f"{out}")
24+ if sys.stdout.isatty():
25+ out, err, returncode = _run_command(
26+ ["colordiff", "-ur", "data", debdiff], returncode=(0, 1)
27+ )
28+ info(f"{out}")
29+ else:
30+ info(f"{out}")
31 found = True
32 if update and yes_or_ask(
33 yes,
34@@ -912,7 +911,7 @@ def check_and_update_bug_attachments(
35 attachment.removeFromBug()
36 except lazr.restfulclient.errors.NotFound as e:
37 debug(e)
38- elif returncode == 0:
39+ else:
40 info(f"{attachment.title} - {attachment.data_link} looks OK.")
41 return True
42

Subscribers

People subscribed via source and target branches