Merge ~fourdollars/pc-enablement/+git/oem-scripts:master into ~oem-solutions-engineers/pc-enablement/+git/oem-scripts:master

Proposed by Shih-Yuan Lee
Status: Merged
Merged at revision: 283db9a4bd6aa1929bb787396b2bdf1af198af74
Proposed branch: ~fourdollars/pc-enablement/+git/oem-scripts:master
Merge into: ~oem-solutions-engineers/pc-enablement/+git/oem-scripts:master
Diff against target: 34 lines (+3/-6)
1 file modified
oem-meta-packages (+3/-6)
Reviewer Review Type Date Requested Status
jeremyszu (community) Approve
Review via email: mp+430973@code.launchpad.net
To post a comment you must log in.
Revision history for this message
jeremyszu (os369510) wrote :

I think it's because we are requiring to do the oem kernel retirement.
There are some codes related to "20.04" need to be adjusted to "22.04"+ but it doesn't matter to this MP.

The MP looks good to me but the other lines:

e.g.

        lines[idx] = lines[idx].replace(
            ", linux-oem-20.04b | linux-oem-20.04,", f", {args.kernel},"
        )

need to consider linux-oem-20.04c, linux-oem-20.04d?

If CI passed, then I think we are good to go.

review: Approve
Revision history for this message
OEM Taipei Bot (oem-taipei-bot) wrote :

[autopkgtest]
autopkgtest-collect-credentials PASS
autopkgtest-oem-scripts-auto PASS
pkg-somerville-meta PASS
pkg-stella-meta PASS
pkg-sutton-meta PASS
bug-bind PASS
get-private-ppa PASS
jq-lp PASS
launchpad-api PASS
lp-bug PASS
pkg-list PASS
review-merge-proposal PASS
run-autopkgtest PASS
setup-apt-dir PASS
bootstrap-meta PASS
mir-bug PASS
oem-meta-packages SKIP exit status 77 and marked as skippable
git-url-insteadof-setting PASS
lp-dl-attm PASS
recovery-from-iso.sh PASS

https://oem-share.canonical.com/partners/lyoncore/share/artifacts/oem-scripts/oem-scripts-1.45-f793292-in-linux-container-jammy

Revision history for this message
OEM Taipei Bot (oem-taipei-bot) wrote :

[autopkgtest]
autopkgtest-collect-credentials PASS
autopkgtest-oem-scripts-auto PASS
pkg-somerville-meta PASS
pkg-stella-meta PASS
pkg-sutton-meta PASS
bug-bind PASS
get-private-ppa PASS
jq-lp PASS
launchpad-api PASS
lp-bug PASS
pkg-list PASS
review-merge-proposal PASS
run-autopkgtest PASS
setup-apt-dir PASS
bootstrap-meta PASS
mir-bug PASS
oem-meta-packages SKIP exit status 77 and marked as skippable
git-url-insteadof-setting PASS
lp-dl-attm PASS
recovery-from-iso.sh PASS

https://oem-share.canonical.com/partners/lyoncore/share/artifacts/oem-scripts/oem-scripts-1.47-a0c8be9-in-linux-container-jammy

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/oem-meta-packages b/oem-meta-packages
2index 2b2e999..59594ba 100755
3--- a/oem-meta-packages
4+++ b/oem-meta-packages
5@@ -501,10 +501,7 @@ def deal_with_kernel_depends(pkg_name, branch, git_dir) -> bool:
6 )
7 if prev != lines[idx]:
8 changed = True
9- elif (
10- args.kernel.startswith("linux-oem-20.04")
11- and f", {args.kernel}," not in lines[idx]
12- ):
13+ elif f", {args.kernel}," not in lines[idx]:
14 lines[idx] = lines[idx].replace(
15 ", linux-oem-20.04b | linux-oem-20.04,", f", {args.kernel},"
16 )
17@@ -553,7 +550,7 @@ def deal_with_debian_modaliases(git_dir: str) -> bool:
18
19 changed = False
20 for i, modalias in enumerate(modaliases):
21- if 'bc0Csc05*' not in modalias:
22+ if "bc0Csc05*" not in modalias:
23 changed = True
24 modaliases[i] = modalias.replace("* meta oem-", "bc0Csc05* meta oem-")
25
26@@ -1829,7 +1826,7 @@ def deal_with_meta_git(pkg_name: str, pkg_info: PkgInfo, bootstrap: bool) -> boo
27 messages.append("grub flavour")
28 if deal_with_maintainer_scripts(pkg_name, branch, git_dir):
29 messages.append("maintainer scripts")
30- if project != 'sutton' and deal_with_debian_modaliases(git_dir):
31+ if project != "sutton" and deal_with_debian_modaliases(git_dir):
32 messages.append("debian/modaliases")
33 if deal_with_gbp_conf(git_dir, branch):
34 messages.append("debian/gbp.conf")

Subscribers

People subscribed via source and target branches