Merge ~fourdollars/pc-enablement/+git/oem-scripts:master into ~oem-solutions-engineers/pc-enablement/+git/oem-scripts:master

Proposed by Shih-Yuan Lee
Status: Merged
Approved by: Yuan-Chen Cheng
Approved revision: 05de5a6cd4f46f8b4672cef3c63bd9604d75c88e
Merged at revision: 68036c24920e89efe0a75c5b209b766a5ac5ed3b
Proposed branch: ~fourdollars/pc-enablement/+git/oem-scripts:master
Merge into: ~oem-solutions-engineers/pc-enablement/+git/oem-scripts:master
Diff against target: 58 lines (+17/-14)
2 files modified
debian/tests/setup-apt-dir (+15/-13)
setup-apt-dir.sh (+2/-1)
Reviewer Review Type Date Requested Status
Yuan-Chen Cheng (community) Approve
Review via email: mp+417461@code.launchpad.net
To post a comment you must log in.
Revision history for this message
OEM Taipei Bot (oem-taipei-bot) wrote :

[autopkgtest]
autopkgtest-collect-credentials PASS
autopkgtest-oem-scripts-auto PASS
pkg-somerville-meta PASS
pkg-stella-meta PASS
pkg-sutton-meta PASS
bootstrap-meta PASS
bug-bind PASS
get-private-ppa PASS
jq-lp PASS
launchpad-api PASS
lp-bug PASS
oem-meta-packages PASS
pkg-list PASS
review-merge-proposal PASS
run-autopkgtest PASS
setup-apt-dir PASS
mir-bug SKIP exit status 77 and marked as skippable
git-url-insteadof-setting PASS
lp-dl-attm PASS
recovery-from-iso.sh PASS

https://oem-share.canonical.com/partners/lyoncore/share/artifacts/oem-scripts/oem-scripts-1.30-05de5a6-in-linux-container-focal

Revision history for this message
Yuan-Chen Cheng (ycheng-twn) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/tests/setup-apt-dir b/debian/tests/setup-apt-dir
2index b46d790..272c700 100644
3--- a/debian/tests/setup-apt-dir
4+++ b/debian/tests/setup-apt-dir
5@@ -45,18 +45,20 @@ else
6 exit 1
7 fi
8
9-setup-apt-dir.sh -c focal -m http://archive.ubuntu.com/ubuntu --i386 -o aptdir.log
10-if [ ! -e aptdir.log ]; then
11- echo "aptdir.log doesn't exist."
12- exit 1
13-fi
14-APTDIR="$(cat aptdir.log)"
15-if [ -n "$APTDIR" ] && [ -d "$APTDIR" ] && [[ "$APTDIR" =~ ^/tmp/apt\. ]]; then
16- apt-cache -o "Dir=$APTDIR" -o "Dir::State::status=$APTDIR/var/lib/dpkg/status" policy libc6:i386 | grep libc6:i386
17- rm -fr "$APTDIR" aptdir.log
18-else
19- echo "APTDIR = '$APTDIR' invalid."
20- exit 1
21-fi
22+for series in xenial bionic focal jammy; do
23+ setup-apt-dir.sh -c "$series" -m http://archive.ubuntu.com/ubuntu --i386 -o aptdir.log
24+ if [ ! -e aptdir.log ]; then
25+ echo "aptdir.log doesn't exist."
26+ exit 1
27+ fi
28+ APTDIR="$(cat aptdir.log)"
29+ if [ -n "$APTDIR" ] && [ -d "$APTDIR" ] && [[ "$APTDIR" =~ ^/tmp/apt\. ]]; then
30+ apt-cache -o "Dir=$APTDIR" -o "Dir::State::status=$APTDIR/var/lib/dpkg/status" policy libc6:i386 | grep libc6:i386
31+ rm -fr "$APTDIR" aptdir.log
32+ else
33+ echo "APTDIR = '$APTDIR' invalid."
34+ exit 1
35+ fi
36+done
37
38 exit 0
39diff --git a/setup-apt-dir.sh b/setup-apt-dir.sh
40index 67adf99..cd55412 100755
41--- a/setup-apt-dir.sh
42+++ b/setup-apt-dir.sh
43@@ -176,7 +176,7 @@ if [ "${#PPA[@]}" != "0" ]; then
44 fi
45
46 case "${CODENAME}" in
47- (bionic|focal)
48+ (xenial|bionic|focal)
49 PUBKEY="790BC7277767219C42C86F933B4FE6ACC0B21F32"
50 ;;
51 (hirsute|impish|jammy)
52@@ -184,6 +184,7 @@ case "${CODENAME}" in
53 ;;
54 (*)
55 echo "${CODENAME} is not supported by setup-apt-dir.sh yet."
56+ exit 1
57 ;;
58 esac
59

Subscribers

People subscribed via source and target branches