Merge ~fourdollars/pc-enablement/+git/oem-scripts:master into ~oem-solutions-engineers/pc-enablement/+git/oem-scripts:master

[Shih-Yuan Lee]

LAUNCHPAD_API=https://api.staging.launchpad.net/ launchpad-api patch bugs/100 tags:='["lp-translations", "focal", "whatever", "tag"]'

[Shih-Yuan Lee (fourdollars)]

[BOT]
$ cat oem-scripts-0.92-d3a0e89-in-docker-focal-summary.log
autopkgtest-collect-credentials PASS
autopkgtest-oem-scripts-auto PASS
pkg-somerville-meta PASS
pkg-stella-meta PASS
pkg-sutton-meta PASS
bug-bind PASS
get-private-ppa PASS
jq-lp PASS
launchpad-api PASS
lp-bug PASS
mir-bug PASS
oem-meta-packages PASS
pkg-list PASS
review-merge-proposal PASS
run-autopkgtest PASS
setup-apt-dir PASS
git-url-insteadof-setting PASS
recovery-from-iso.sh PASS
mir-bug-verification PASS
https://paste.ubuntu.com/p/2RHWs849bp/ oem-scripts-0.92-d3a0e89-in-docker-focal-complete.log

[jeremyszu (os369510)]

# ./launchpad-api patch bugs/1923555 tags:='["stella-decaf-c","cooexy"]'

works good but it will overwrite all tags instead of append.

@4$,

Is it expected?

review: Needs Information

[Shih-Yuan Lee (fourdollars)]

Yes, it is the design of Launchpad API.

[jeremyszu (os369510)]

got it, approve since this is a new feature.
Let's implement an append method if need.

review: Approve

diff --git a/debian/changelog b/debian/changelog
index e1bfb43..7f3b9da 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,10 @@
+oem-scripts (0.92) UNRELEASED; urgency=medium
+
+  * debian/tests/launchpad-api,
+    launchpad-api: Support PATCH method.
+
+ -- Shih-Yuan Lee (FourDollars) <[e-mail]>  Tue, 11 May 2021 14:10:31 +0800
+
 oem-scripts (0.91) focal; urgency=medium
 
   * pkg-list: Fix the problem when checking the dependencies.
diff --git a/debian/tests/launchpad-api b/debian/tests/launchpad-api
index 3d6fa76..ff71689 100644
--- a/debian/tests/launchpad-api
+++ b/debian/tests/launchpad-api
@@ -1,8 +1,19 @@
 #!/bin/bash
 
+export LAUNCHPAD_API="https://api.staging.launchpad.net/"
+
+launchpad-api patch bugs/100 tags:='["focal"]'
+if [ "$(launchpad-api get bugs/100 | jq -r '.tags|join(" ")')" != "focal" ]; then
+    exit 1
+fi
+
+launchpad-api patch bugs/100 tags:='["lp-translations"]'
+if [ "$(launchpad-api get bugs/100 | jq -r '.tags|join(" ")')" != "lp-translations" ]; then
+    exit 1
+fi
+
 export LAUNCHPAD_TOKEN="::"
 
-export LAUNCHPAD_API="https://api.staging.launchpad.net/"
 if [ "$(launchpad-api get bugs/1 | jq -r .web_link)" != "https://bugs.staging.launchpad.net/bugs/1" ]; then
     exit 1
 fi
diff --git a/launchpad-api b/launchpad-api
index e7736a5..d812b8f 100755
--- a/launchpad-api
+++ b/launchpad-api
@@ -100,6 +100,18 @@ get_api()
         "$@"
 }
 
+patch_api()
+{
+    api=$(parse_api "$1")
+    if [ -z "$api" ]; then
+        return
+    fi
+    shift
+    http --check-status --ignore-stdin --json PATCH "$api" \
+        Authorization:"OAuth realm=\"${LAUNCHPAD_API}/\", oauth_consumer_key=\"${oauth_consumer_key}\", oauth_nonce=\"$(date +%s)\", oauth_signature=\"%26${oauth_token_secret}\", oauth_signature_method=\"PLAINTEXT\", oauth_timestamp=\"$(date +%s)\", oauth_token=\"${oauth_token}\", oauth_version=\"1.0\"" \
+        "$@"
+}
+
 post_api()
 {
     api=$(parse_api "$1")
@@ -119,7 +131,6 @@ post_api()
         "$@"
 }
 
-
 if [ -n "$LAUNCHPAD_TOKEN" ]; then
     read -r oauth_token oauth_token_secret oauth_consumer_key < <(echo "$LAUNCHPAD_TOKEN" | tr ':' ' ')
     if [ -z "$oauth_consumer_key" ]; then
@@ -143,6 +154,10 @@ case "$1" in
         shift
         get_api "$@"
         ;;
+    ("patch"|"PATCH")
+        shift
+        patch_api "$@"
+        ;;
     ("post"|"POST")
         shift
         post_api "$@"