Ubuntu
base-files package

Code review comment for lp:~fougner/ubuntu/oneiric/base-files/fix-for-790050

  1. Oneiric (11.10)
  2. fix-for-790050
  3. Merge into oneiric
Revision history for this message
Barry Warsaw (barry) wrote :

Hi Alexander, thanks for your contribution to Ubuntu.

It looks to me like your patch removes too much from share/profile. While your commit message specifically says that you're removing an unneeded comment from share/profile, you're actually also removing the sourcing of /etc/profile.d/*.sh. That clearly can't be right, e.g. it would stop the sourcing of bash_completion.sh on my Oneiric machine.

Can you please push an update to your branch? I'll be happy to re-review and sponsor it when you do.

review: Needs Fixing

« Back to merge proposal