Code review comment for lp:~fougner/ubuntu-packaging-guide/retheming

Revision history for this message
Daniel Holbach (dholbach) wrote :

The diff is not as bad as it looks. I'm quite happy with the changes (for a first start with the retheming). I would like to get somebody else's opinion though.

 - daniel@miyazaki:~$ wget -q http://loco.ubuntu.com/media/css/newstyle.css
   daniel@miyazaki:~$ diff -u newstyle.css bzr/ubuntu-packaging-guide.retheming/themes/ubuntu/static/newstyle.css
   daniel@miyazaki:~$

 - Actual theme changes: http://paste.ubuntu.com/642710/ (compared to standard sphinx theme)

 - Changes in the CSS:
   daniel@miyazaki:~$ bzr branch lp:ubuntu-website/light-django-theme
   Branched 31 revision(s).

   daniel@miyazaki:~$ diff -u light-django-theme/media/css/default.css bzr/ubuntu-packaging-guide.retheming/themes/ubuntu/static/light-django-theme.css
   --- light-django-theme/media/css/default.css 2011-07-12 17:29:45.334779000 +0200
   +++ bzr/ubuntu-packaging-guide.retheming/themes/ubuntu/static/light-django-theme.css 2011-07-12 17:26:58.420591381 +0200
   @@ -876,11 +876,11 @@
    }

    #page-footer {
   - background: url("../images/footer.png") repeat-x scroll 0 0 #EEECEA
   + background: url("footer.png") repeat-x scroll 0 0 #EEECEA
    }

     #page-footer .container {
   - background: url("../images/footer.png") repeat-x scroll 0 0 #EEECEA;
   + background: url("footer.png") repeat-x scroll 0 0 #EEECEA;
         padding: 0px 10px;
         width: 960px;
     }
   daniel@miyazaki:~$

« Back to merge proposal