Juju Charms Collection
logstash package

Code review comment for lp:~foli/charms/trusty/logstash/add-lumberjack-protocol

  1. Trusty Tahr (14.04)
  2. add-lumberjack-protocol
  3. Merge into trunk
Revision history for this message
Charles Butler (lazypower) wrote :

All of this looks good to me. I just have a single comment - that we need to get a test built that leverages the lumberjack relationship and validate everything is working so we know if it breaks in the future.

I'll assign a bug for this and happily merge. Thanks for the contributions!

review: Approve

« Back to merge proposal