Merge ~fnordahl/ubuntu/+source/ovn:ubuntu/focal into ~ubuntu-server-dev/ubuntu/+source/ovn:ubuntu/focal

Proposed by Frode Nordahl
Status: Merged
Merge reported by: James Page
Merged at revision: e08430c0daa2fe56dde294c78fb995c82f93d655
Proposed branch: ~fnordahl/ubuntu/+source/ovn:ubuntu/focal
Merge into: ~ubuntu-server-dev/ubuntu/+source/ovn:ubuntu/focal
Diff against target: 67 lines (+47/-0)
3 files modified
debian/changelog (+6/-0)
debian/patches/ovn-controller-ofctrl-probe-interval.patch (+40/-0)
debian/patches/series (+1/-0)
Reviewer Review Type Date Requested Status
Ubuntu Server Developers Pending
Review via email: mp+393443@code.launchpad.net
To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/debian/changelog b/debian/changelog
index 600b58d..a3fa1ee 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,9 @@
1ovn (20.03.1-0ubuntu1.1) focal; urgency=medium
2
3 * d/p: ovn-controller-ofctrl-probe-interval.patch (LP: #1899369).
4
5 -- Frode Nordahl <frode.nordahl@canonical.com> Fri, 06 Nov 2020 08:21:03 +0000
6
1ovn (20.03.1-0ubuntu1) focal; urgency=medium7ovn (20.03.1-0ubuntu1) focal; urgency=medium
28
3 * New upstream point release (LP: #1897248).9 * New upstream point release (LP: #1897248).
diff --git a/debian/patches/ovn-controller-ofctrl-probe-interval.patch b/debian/patches/ovn-controller-ofctrl-probe-interval.patch
4new file mode 10064410new file mode 100644
index 0000000..bf14b32
--- /dev/null
+++ b/debian/patches/ovn-controller-ofctrl-probe-interval.patch
@@ -0,0 +1,40 @@
1Description: Cherry-pick not yet tagged upstream backport to branch-20.03
2Origin: https://github.com/ovn-org/ovn/commit/028d6db38ff56018ba40b3abb3da94ba7a724ffa
3Applied-Upstream: commit: 028d6db38ff56018ba40b3abb3da94ba7a724ffa
4
5From 028d6db38ff56018ba40b3abb3da94ba7a724ffa Mon Sep 17 00:00:00 2001
6From: Han Zhou <hzhou@ovn.org>
7Date: Mon, 24 Aug 2020 18:48:06 -0700
8Subject: [PATCH] ovn-controller: Disable ofctrl probe by default.
9
10The commit c99069c8934c ("ovn-controller: Provide the option to configure
11inactivity probe interval for OpenFlow conn") supports configuring probe
12interval for the openflow connection of ofctrl module. However, it changed the
13default behavior. The default OpenFlow connection probe was defaults to 0
14(disabled), because the connection is always unix socket (to local OVS br-int
15bridge). After that patch it changed to probe every 5 seconds, which was not
16the intension.
17
18This patch restores the default behavior of disabling the probe by setting
19default value to 0, while keeping the capability of letting user configure it.
20
21Cc: Numan Siddique <nusiddiq@redhat.com>
22Acked-by: Mark Michelson <mmichels@redhat.com>
23Signed-off-by: Han Zhou <hzhou@ovn.org>
24---
25 controller/ovn-controller.c | 2 +-
26 1 file changed, 1 insertion(+), 1 deletion(-)
27
28diff --git a/controller/ovn-controller.c b/controller/ovn-controller.c
29index 4d21ba0fd..53b70e500 100644
30--- a/controller/ovn-controller.c
31+++ b/controller/ovn-controller.c
32@@ -76,7 +76,7 @@ static unixctl_cb_func engine_recompute_cmd;
33
34 #define DEFAULT_BRIDGE_NAME "br-int"
35 #define DEFAULT_PROBE_INTERVAL_MSEC 5000
36-#define OFCTRL_DEFAULT_PROBE_INTERVAL_SEC 5
37+#define OFCTRL_DEFAULT_PROBE_INTERVAL_SEC 0
38
39 #define CONTROLLER_LOOP_STOPWATCH_NAME "ovn-controller-flow-generation"
40
diff --git a/debian/patches/series b/debian/patches/series
0new file mode 10064441new file mode 100644
index 0000000..d55d9eb
--- /dev/null
+++ b/debian/patches/series
@@ -0,0 +1 @@
1ovn-controller-ofctrl-probe-interval.patch

Subscribers

People subscribed via source and target branches