Merge ~fnordahl/ubuntu/+source/ovn:ubuntu/focal into ~ubuntu-server-dev/ubuntu/+source/ovn:ubuntu/focal

Proposed by Frode Nordahl
Status: Merged
Merge reported by: James Page
Merged at revision: e08430c0daa2fe56dde294c78fb995c82f93d655
Proposed branch: ~fnordahl/ubuntu/+source/ovn:ubuntu/focal
Merge into: ~ubuntu-server-dev/ubuntu/+source/ovn:ubuntu/focal
Diff against target: 67 lines (+47/-0)
3 files modified
debian/changelog (+6/-0)
debian/patches/ovn-controller-ofctrl-probe-interval.patch (+40/-0)
debian/patches/series (+1/-0)
Reviewer Review Type Date Requested Status
Ubuntu Server Developers Pending
Review via email: mp+393443@code.launchpad.net
To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index 600b58d..a3fa1ee 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,9 @@
6+ovn (20.03.1-0ubuntu1.1) focal; urgency=medium
7+
8+ * d/p: ovn-controller-ofctrl-probe-interval.patch (LP: #1899369).
9+
10+ -- Frode Nordahl <frode.nordahl@canonical.com> Fri, 06 Nov 2020 08:21:03 +0000
11+
12 ovn (20.03.1-0ubuntu1) focal; urgency=medium
13
14 * New upstream point release (LP: #1897248).
15diff --git a/debian/patches/ovn-controller-ofctrl-probe-interval.patch b/debian/patches/ovn-controller-ofctrl-probe-interval.patch
16new file mode 100644
17index 0000000..bf14b32
18--- /dev/null
19+++ b/debian/patches/ovn-controller-ofctrl-probe-interval.patch
20@@ -0,0 +1,40 @@
21+Description: Cherry-pick not yet tagged upstream backport to branch-20.03
22+Origin: https://github.com/ovn-org/ovn/commit/028d6db38ff56018ba40b3abb3da94ba7a724ffa
23+Applied-Upstream: commit: 028d6db38ff56018ba40b3abb3da94ba7a724ffa
24+
25+From 028d6db38ff56018ba40b3abb3da94ba7a724ffa Mon Sep 17 00:00:00 2001
26+From: Han Zhou <hzhou@ovn.org>
27+Date: Mon, 24 Aug 2020 18:48:06 -0700
28+Subject: [PATCH] ovn-controller: Disable ofctrl probe by default.
29+
30+The commit c99069c8934c ("ovn-controller: Provide the option to configure
31+inactivity probe interval for OpenFlow conn") supports configuring probe
32+interval for the openflow connection of ofctrl module. However, it changed the
33+default behavior. The default OpenFlow connection probe was defaults to 0
34+(disabled), because the connection is always unix socket (to local OVS br-int
35+bridge). After that patch it changed to probe every 5 seconds, which was not
36+the intension.
37+
38+This patch restores the default behavior of disabling the probe by setting
39+default value to 0, while keeping the capability of letting user configure it.
40+
41+Cc: Numan Siddique <nusiddiq@redhat.com>
42+Acked-by: Mark Michelson <mmichels@redhat.com>
43+Signed-off-by: Han Zhou <hzhou@ovn.org>
44+---
45+ controller/ovn-controller.c | 2 +-
46+ 1 file changed, 1 insertion(+), 1 deletion(-)
47+
48+diff --git a/controller/ovn-controller.c b/controller/ovn-controller.c
49+index 4d21ba0fd..53b70e500 100644
50+--- a/controller/ovn-controller.c
51++++ b/controller/ovn-controller.c
52+@@ -76,7 +76,7 @@ static unixctl_cb_func engine_recompute_cmd;
53+
54+ #define DEFAULT_BRIDGE_NAME "br-int"
55+ #define DEFAULT_PROBE_INTERVAL_MSEC 5000
56+-#define OFCTRL_DEFAULT_PROBE_INTERVAL_SEC 5
57++#define OFCTRL_DEFAULT_PROBE_INTERVAL_SEC 0
58+
59+ #define CONTROLLER_LOOP_STOPWATCH_NAME "ovn-controller-flow-generation"
60+
61diff --git a/debian/patches/series b/debian/patches/series
62new file mode 100644
63index 0000000..d55d9eb
64--- /dev/null
65+++ b/debian/patches/series
66@@ -0,0 +1 @@
67+ovn-controller-ofctrl-probe-interval.patch

Subscribers

People subscribed via source and target branches