Code review comment for lp:~fluidity-core/fluidity/shallow-water-dev

Hi Cian,
     These options are read in populate_state and make things happen in
Elements.F90 and various other places.

--cjc

On 09/11/11 16:17, Cian Wilson wrote:
> Review: Needs Information
>
> Hi Colin,
>
> Only had a quick glance but can I check if these changes provide any new functionality to fluidity itself? I ask because you've changed mesh_options.rn[cg] and these options are now appearing in the fluidity schema too but I can't see how they're applicable to fluidity as I can only trace them back to the hybridized helmholtz solver. If they're not used in fluidity then I don't think they should appear in a piece of the schema that is visible within an flml but I may be missing something.
>
> Unrelated to this merge but the parent option (geometry/mesh/from_mesh/constrain_type) for these new options is undocumented in the schema.
>
> Cheers,
> Cian