Code review comment for lp:~fluidity-core/fluidity/prescribed-regions-adaptivity

Revision history for this message
Samuel Parkinson (s-parkinson11) wrote :

Hey Stephan,

Generally all top notch. Just a few comments:
1) in Mba2D_integration.F90 there is a comment saying "not sure this will work with lock_faces". What does this mean?
2) lots of testing which is good, but errors get displayed when running the new test saying "The following boundary ids were specified, but they don't appear in the surface mesh:".
3) You mention that only certain discretisations are supported. Should there be a manual entry listing the caveats under which this is tested and is known to work.

Other than that it's all good.

« Back to merge proposal