Code review comment for lp:~fluidity-core/fluidity/prescribed-regions-adaptivity

Revision history for this message
Stephan Kramer (s-kramer) wrote :

Thanks for testing this, Rhodri!

That warning exists not because "in theory it should work but I haven't had time to test it". It's simply not implemented, the stuff I added for 2d adaptivity is in a completely different code path. So there's three possible outcomes:
1) It crashes immediately
2) It goes through an adapt but the internal boundary dissapears (this is what would happen in 2D before)
3) It somehow magically works (quite unlikely)

Now if there's demand I'm quite happy at implementing it for 3d as well (this should be a lot easier now with the new add_faces() functionality), but I don't think this needs to go in this merge.

« Back to merge proposal