Code review comment for lp:~fluidity-core/fluidity/iceshelf

Revision history for this message
Stephan Kramer (s-kramer) wrote :

The DG Neumann bc is being further developed on this branch https://code.launchpad.net/~fluidity-core/fluidity/DG_Neumann. It needed fixing to work with subcycling. It now needs some proper tests.

This merge seems to have all sorts of other unrelated stuff: FLHere(), /io/adhere_to_output_mesh_continuity, /top_position/align_with_geoids, regularise_aspect_ratio, subshelf_hydrostatic_pressure... These all may, or may not be useful additions but should be proposed for a merge seperately.

Please have a look at the diff with the trunk yourself before you put anything up for merge proposal. Reviewing is a lot of work, so we expect things to be cleaned up properly before requesting a merge (no commented out code, etc.)

review: Disapprove

« Back to merge proposal