Code review comment for lp:~fluidity-core/fluidity/fix_coord_transformations

Revision history for this message
Simon Mouradian (mouradian) wrote :

In femtools/Coordinates.F90:L303
subroutine spherical_polar_2_lon_lat_height returns the height as one of:
-) Distance from referenceRadius (if referenceRadius is present)
-) Distance from center (i.e. equal to the radius) if referenceRadius is absent.

This behavious is inconsistent with the inverse routine lon_lat_height_2_spherical_polar. To maintain consistency, the height should be returned as the distance from the surface_radius (global parameter) if the referenceRadius is not present.

review: Needs Fixing

« Back to merge proposal