Code review comment for lp:~fluidity-core/fluidity/fix-lagr-detectors

Revision history for this message
Rhodri Davies (rhodri-davies) wrote :

Hi Michael,

The changes looks good to me, although it may be worth somebody that better understands how detectors are handled in parallel taking a look at the MPI changes before the merge is approved.

One issue: there don't seem to be any modifications to tests to verify that these errors will not crop up again in the future. Is there any way some of the lagrangian detector cases could be modified to test these things? I guess a test for the individual lagrangian detector I/O bug could easily be added to an existing test, but how about the other bug?

Rhod

« Back to merge proposal