Code review comment for lp:~flscogna/ubuntu-terminal-app/profile-selection

Revision history for this message
Filippo Scognamiglio (flscogna) wrote :

Alan, we can theoretically hide the keyboard button, but what about the row? If we hide only the button, we would basically have a black useless rectangle at the bottom.
Let's discuss some options:

1) Leave the current situation, with a useless bar and a useless button. (quite bad but predictable)
2) Hide the keyboard bar when no profiles are selected. (might be confusing?)
3) Force at least one profiles to be active (e.g. your ubuntu layout).

What do you think?

« Back to merge proposal