Code review comment for lp:~florian-rathgeber/instant/paths-module-fixes

Thanks!

The if test for generating the cache dir might fail for clusters, for
jobs submitted to several nodes. For this purpose there is a function in
build.py called makedirs, which fails alright, but silently so.

If you do not mind can you use this function for the purpose of this
patch? It is also more logical to move makedirs to the paths.py module.
If you could fix that too it would be excellent!

Johan

On 03/17/2012 08:10 PM, Florian Rathgeber wrote:
> Florian Rathgeber has proposed merging
> lp:~florian-rathgeber/instant/paths-module-fixes into lp:instant.
>
> Requested reviews: Instant Core Team (instant-core)
>
> For more details, see:
> https://code.launchpad.net/~florian-rathgeber/instant/paths-module-fixes/+merge/98065
>
> A few small fixes for the paths utility module:
>
> * Fix docstrings * Add helper function for checking and creating
> directories that don't yet exist * Call instant_error when directory
> creation fails